Removed use of asyncio.coroutines.debug_wrapper#127
Closed
wallies wants to merge 3 commits intoMagicStack:masterfrom
wallies:python3.7
Closed
Removed use of asyncio.coroutines.debug_wrapper#127wallies wants to merge 3 commits intoMagicStack:masterfrom wallies:python3.7
wallies wants to merge 3 commits intoMagicStack:masterfrom
wallies:python3.7
Conversation
gukoff
reviewed
Mar 10, 2018
| self._coroutine_wrapper_set = True | ||
|
|
||
| if sys_version_info >= (3, 7, 0): | ||
| pass |
There was a problem hiding this comment.
This looks strange. Why not if sys_version_info < (3, 7, 0)?
Member
|
Closing this in favor of #138 |
Member
|
Thanks so much for contributing this though! It's just the other PR is more developed and covers more cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully should fix #126
Wider use of sys.set_coroutine_wrapper will need to be looked into.
Warning: I am a relative newbie to python, just trying to help out.